jiayuasu commented on code in PR #1069: URL: https://github.com/apache/sedona/pull/1069#discussion_r1379150033
########## docs/api/sql/Function.md: ########## @@ -2530,7 +2530,7 @@ PROJCS["WGS 84 / Pseudo-Mercator", Format: ``` -ST_Transform (A: Geometry, SourceCRS: String, TargetCRS: String, [Optional] lenientMode: Boolean) +ST_Transform (A: Geometry, [Optional] SourceCRS: String, TargetCRS: String, [Optional] lenientMode: Boolean) Review Comment: Please provide overloaded variants of this function. Don't just specify `optional`. ########## python/sedona/sql/st_functions.py: ########## Review Comment: New Python DataFrame API needs to be tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
