jiayuasu commented on code in PR #1066:
URL: https://github.com/apache/sedona/pull/1066#discussion_r1379443076
##########
python/tests/sql/test_function.py:
##########
@@ -96,6 +96,9 @@ def test_st_buffer(self):
function_df = self.spark.sql("select ST_Buffer(polygondf.countyshape,
1) from polygondf")
function_df.show()
+ function_df = self.spark.sql("select ST_Buffer(polygondf.countyshape,
10, 'endcap=square') from polygondf")
+ function_df.show()
Review Comment:
Please do not do `show` in tests. If the old tests use `show`, remove them
as well. Use assertion to check the correctnesst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
