Kontinuation commented on code in PR #1520:
URL: https://github.com/apache/sedona/pull/1520#discussion_r1678663477


##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala:
##########
@@ -1437,6 +1439,60 @@ case class ST_ForceRHR(inputExpressions: Seq[Expression])
   }
 }
 
+case class ST_GeneratePoints(inputExpressions: Seq[Expression], randomSeed: 
Option[Long] = None)
+    extends Expression
+    with Nondeterministic
+    with ExpectsInputTypes
+    with CodegenFallback
+    with ExpressionWithRandomSeed {
+
+  def this(inputExpressions: Seq[Expression]) = this(inputExpressions, 
Some(0L))

Review Comment:
   Ah, I made a mistake when writing the example code. It should be
   
   ```
   case class ST_GeneratePoints(inputExpressions: Seq[Expression], randomSeed: 
Long) extends Expression
       with Nondeterministic
       with ExpectsInputTypes
       with CodegenFallback  {
   
     def this(inputExpressions: Seq[Expression]) = this(inputExpressions, 
Utils.random.nextLong())
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to