zhangfengcdt commented on code in PR #1557:
URL: https://github.com/apache/sedona/pull/1557#discussion_r1729059062
##########
common/src/test/java/org/apache/sedona/common/FunctionsTest.java:
##########
@@ -1622,6 +1622,126 @@ public void numPointsUnsupported() throws Exception {
assertEquals(expected, e.getMessage());
}
+ @Test
Review Comment:
I would suggest we break down this unit test into multiple ones while each
of them test one geometry type. Note that it would highlight the difference
between multi-point and other types where ordering matters.
##########
common/src/main/java/org/apache/sedona/common/Functions.java:
##########
@@ -873,6 +873,14 @@ public static Geometry removePoint(Geometry linestring,
int position) {
return null;
}
+ public static Geometry removeRepeatedPoints(Geometry geom, double tolerance)
{
+ return GeometryDuplicateCoordinateRemover.transform(geom, tolerance);
Review Comment:
I am not sure `transform` is an intuitive name to use here, maybe remove?
##########
spark/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala:
##########
@@ -1821,6 +1821,18 @@ class functionTestScala
3) shouldBe None
}
+ it("Should pass ST_RemoveRepeatedPoints") {
Review Comment:
I think we'd include all the example cases in the postgis document here -
https://postgis.net/docs/ST_RemoveRepeatedPoints.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
