Kontinuation commented on code in PR #1593:
URL: https://github.com/apache/sedona/pull/1593#discussion_r1770721538
##########
.pre-commit-config.yaml:
##########
@@ -10,6 +10,10 @@ repos:
hooks:
- id: identity
- id: check-hooks-apply
+ - repo: https://github.com/psf/black-pre-commit-mirror
+ rev: 24.8.0
+ hooks:
+ - id: black
Review Comment:
I saw that .ipynb files are also formatted. Is the `black` hook capable of
formatting jupyter notebook files? I've also noticed that there's a
[`black-jupyter`
hook](https://black.readthedocs.io/en/stable/integrations/source_version_control.html#jupyter-notebooks)
for this purpose.
##########
.github/linters/ruff.toml:
##########
@@ -39,8 +39,8 @@ target-version = "py38"
# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by
default.
# Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or
# McCabe complexity (`C901`) by default.
-select = ["E4", "E7", "E9", "F"]
-ignore = ["E721", "E722", "E731", "F401", "F402", "F403", "F405", "F811",
"F821", "F822", "F841", "F901"]
+select = ["E3", "E4", "E5", "E7", "E9", "F"]
+ignore = ["E501", "E721", "E722", "E731", "F401", "F402", "F403", "F405",
"F811", "F821", "F822", "F841", "F901"]
Review Comment:
We are using black as the python linter. Will black use lint configs defined
in `ruff.toml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
