twu425 commented on issue #1584: URL: https://github.com/apache/sedona/issues/1584#issuecomment-2370268089
> A few notes: > > * `cdm-core` has to be bundled in the shaded package, we include it in the shaded pom.xml to make it compile rather than provided. > * `guava` is better shaded than excluded, since we don't know whether the guava jar shipped with spark is compatible with sedona or not, and shading guava is a common practice. > * other package exclusion seems to be OK. Apache commons has good backward compatibility and the versions shipped with spark is later than what we bundled. I agree with @Kontinuation. Guava is tricky, as I learned it when upgrading Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
