paleolimbot commented on PR #1767: URL: https://github.com/apache/sedona/pull/1767#issuecomment-2610965056
I still have some questions here, but it does work! - Where should this function live? I had been thinking `Adapter.toArrow()` but the `Adapter` is mostly a Scala wrapper and this is very much not Scala. I could leave it in its own `sedona.utils.geoarrow` too. - I updated `geoarrow-types` to be compatible with Python 3.7 ( https://github.com/geoarrow/geoarrow-python/pull/62 ), but until that is on pip we can't add it to the `Pipfile` and it's harder to test that branch in CI. - I think the ultimate solution here is to hook in at the Scala/Java level to add the field metadata we need there. That would also give options other than WKB that might be faster, but we'd need the ability to add field metadata. I couldn't find anything immediately in https://github.com/apache/spark/tree/fe29f83127f813e67764e40b7b9672ea358ed6ce/sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/arrow but I'm not sure I would know exactly where to find that. - Should conversion of arbitrary nested geometry fields be handled in this PR or a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
