zhangfengcdt commented on PR #2005: URL: https://github.com/apache/sedona/pull/2005#issuecomment-3005611162
> Yes that makes sense, but the hard-coded outputs from the original scala tests would clutter up the codebase too much due to their sheer size (possibly like 1000+ lines for some test cases). IMO, it's not reasonable to hard code those outputs. Then at that point, if we're not extending the scala tests, is it worth still replicate those tests exactly in in python (`test_geoseries.py`)? > > How do you feel about hard-coding the geopandas match test cases instead? Those ones are smaller, so the expected results won't be too bad. Oh, I meant we can replicate the types of checks from that scala test, not the exact data, we can use smaller inputs for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
