Subham-KRLX commented on PR #2024:
URL: https://github.com/apache/sedona/pull/2024#issuecomment-3016348966
@jbampton @james-willis @jiayuasu
I’ve completed all requested changes for standardizing XML license headers
(#2024), but some CI checks are failing. Here’s my understanding of the
failures:
### **1. Example Project Build Failures (Spark 3.4/3.5)**
- **Observed**: Tests fail in `sedona-examples` module.
- **My Checks**:
- Ran locally with `mvn clean test -pl :sedona-examples -Pspark-3.4` →
**Same failure**.
- Compared with `master` branch → Tests pass there, so this *might* relate
to my changes.
- Reviewed POMs → No dependency/version conflicts introduced.
- **Possible Cause**:
- Could the license header changes affect how XML resources are read in
tests?
- Or is this an environment/config issue?
### **2. Pre-commit Linting Failure**
- **Observed**: `Lint / Run pre-commit` job fails.
- **My Checks**:
- Ran `pre-commit run --all-files` locally → **Passes**.
- Verified `.pre-commit-config.yaml` matches other hooks’ patterns.
- **Possible Cause**:
- CI-specific issue (e.g., cached hooks)?
- Or did I miss a hidden config (like `exclude:` rules)?
### **Request for Guidance**
Could you help clarify:
1. Are these failures related to my changes, or pre-existing?
2. If related, what’s the root cause? (I’m happy to fix it!)
3. If unrelated, should we merge despite these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
