petern48 commented on code in PR #2021:
URL: https://github.com/apache/sedona/pull/2021#discussion_r2175986295
##########
python/sedona/geopandas/geoseries.py:
##########
@@ -327,9 +351,44 @@ def type(self):
raise NotImplementedError("This method is not implemented yet.")
@property
- def length(self):
- # Implementation of the abstract method
- raise NotImplementedError("This method is not implemented yet.")
+ def length(self) -> pspd.Series:
+ """
+ Returns a Series containing the length of each geometry in the
GeoSeries.
+
+ In the case of a (Multi)Polygon it measures the length of its exterior
(i.e. perimeter).
+
+ For a GeometryCollection it measures sums the values for each of the
individual geometries.
+
+ Returns
+ -------
+ Series
+ A Series containing the length of each geometry.
+
+ Examples
+ --------
+ >>> from shapely.geometry import Polygon
+ >>> import geopandas as gpd
+ >>> from sedona.geopandas import GeoSeries
+
+ >>> gs = GeoSeries([Point(0, 0), LineString([(0, 0), (1, 1)]),
Polygon([(0, 0), (1, 0), (1, 1)]), GeometryCollection([Point(0, 0),
LineString([(0, 0), (1, 1)]), Polygon([(0, 0), (1, 0), (1, 1)])])])
+ >>> gs.length
+ 0 0.000000
+ 1 1.414214
+ 2 3.414214
+ 3 4.828427
+ dtype: float64
+ """
+ col = self.get_first_geometry_column()
+ select = f"""
+ CASE
+ WHEN GeometryType(`{col}`) IN ('LINESTRING',
'MULTILINESTRING') THEN ST_Length(`{col}`)
+ WHEN GeometryType(`{col}`) IN ('POLYGON', 'MULTIPOLYGON') THEN
ST_Perimeter(`{col}`)
+ WHEN GeometryType(`{col}`) IN ('POINT', 'MULTIPOINT') THEN 0.0
+ WHEN GeometryType(`{col}`) IN ('GEOMETRYCOLLECTION') THEN
ST_Length(`{col}`) + ST_Perimeter(`{col}`)
+ END"""
Review Comment:
I'm good with skipping this. The sql queries are internal anyways. I don't
see the need to add an extra import. Though if we do decide we want this, we
can put this in the helper function instead of the string input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
