petern48 opened a new issue, #2049:
URL: https://github.com/apache/sedona/issues/2049

   After we get index support (#2036), revisit the `align` behavior for the 
row-wise operations, discussed in this PR originally 
https://github.com/apache/sedona/pull/2038.
   
   Specifically we should investigate the comments copilot made. The suggested 
fixes weren't right, but we may be missing something.
   - Set the index properly. It seems to be a union.
   ```python
   geoseries = gpd.GeoSeries([Polygon([(0, 0), (1, 0), (1, 1)]), Polygon([(0, 
0), (1, 0), (1, 1)]), Polygon([(0, 0), (1, 0), (1, 1)])], index=[1, 2, 3])
   geoseries2 = gpd.GeoSeries([Polygon([(0, 0), (1, 0), (1, 1)]), Polygon([(0, 
0), (1, 0), (1, 1)]), Polygon([(0, 0), (1, 0), (1, 1)])], index=[0, 1, 2])
   res = geoseries.intersection(geoseries2, align=True)
   print(res)
   print(res.index)
   
   0                              None
   1    POLYGON ((0 0, 1 1, 1 0, 0 0))
   2    POLYGON ((0 0, 1 1, 1 0, 0 0))
   3                              None
   dtype: geometry
   Index([0, 1, 2, 3], dtype='int64')
   ```
   
   - Investigate: Is it really an `outer` join really correct in all cases? Or 
could it be something more along the lines of a union of left and right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to