petern48 commented on PR #2071:
URL: https://github.com/apache/sedona/pull/2071#issuecomment-3063804893
We don't necessarily have to drop support for shapely 1 in all of sedona if
you don't want to. We could also just drop it for geopandas specifically, or
skip this test for shapely 1 and accept the difference. Of course, updating
documentation however necessary. Dropping support would make my life easier,
but it's probably not necessarily at this point.
Looking at the error output, it looks like shapely 1, automatically
interprets `Polygon()` as `GEOMETRY COLLECTION`.
```python
expected = gpd.GeoSeries(
[
Point(0, 0),
Point(0, 0),
MultiPoint([(0, 0), (1, 1), (0, 1), (1, 0)]),
Polygon(),
None,
]
)
```
From the logs: (idk why it's formatted this way, but GeometryCollection
Empty corresponds to the Polygon() object)
```
expected = 0 POINT (0.00000 0.00000)
1 POINT (0.00000 0.00000)
2 MUL... GEOMETRYCOLLECTION EMPTY
4 None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
