Copilot commented on code in PR #2113:
URL: https://github.com/apache/sedona/pull/2113#discussion_r2213641297
##########
python/tests/geopandas/test_geoseries.py:
##########
@@ -331,10 +332,73 @@ def test_to_json(self):
pass
def test_to_wkb(self):
- pass
+ if parse_version(shapely.__version__) < parse_version("2.0.0"):
+ return
Review Comment:
[nitpick] Returning silently in a test can hide skipped cases without
reporting. Use `pytest.skip("reason")` to clearly mark tests as skipped when
the shapely version is below the required threshold.
```suggestion
pytest.skip("Shapely version must be 2.0.0 or higher for this
test.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
