Kimahriman commented on code in PR #2098:
URL: https://github.com/apache/sedona/pull/2098#discussion_r2217787067
##########
pom.xml:
##########
@@ -85,7 +85,12 @@
<spark.compat.version>3.4</spark.compat.version>
<spark.major.version>3</spark.major.version>
<log4j.version>2.19.0</log4j.version>
- <graphframe.version>0.8.3-spark3.4</graphframe.version>
+
+
+ <graphframes.groupId>io.graphframes</graphframes.groupId>
+
<graphframes.artifactId>graphframes-spark${spark.major.version}_${scala.compat.version}</graphframes.artifactId>
+ <!--There is no 3.4 version of GraphFrames, so we use 0.9.0-spark3.5-->
+ <graphframes.version>0.9.0-spark3.5</graphframes.version>
Review Comment:
Versioning was fixed so this can just be
```suggestion
<graphframes.version>0.9.2</graphframes.version>
```
##########
pom.xml:
##########
@@ -85,7 +85,12 @@
<spark.compat.version>3.4</spark.compat.version>
<spark.major.version>3</spark.major.version>
<log4j.version>2.19.0</log4j.version>
- <graphframe.version>0.8.3-spark3.4</graphframe.version>
+
+
+ <graphframes.groupId>io.graphframes</graphframes.groupId>
+
<graphframes.artifactId>graphframes-spark${spark.major.version}_${scala.compat.version}</graphframes.artifactId>
Review Comment:
Probably don't need these as variables anymore if we're using the same thing
for all Spark versions now, can just inline this
##########
pom.xml:
##########
@@ -752,9 +755,11 @@
<hadoop.version>3.4.1</hadoop.version>
<log4j.version>2.24.3</log4j.version>
<slf4j.version>2.0.16</slf4j.version>
- <graphframe.version>0.8.3-spark3.5</graphframe.version>
+
<scala.version>2.13.12</scala.version>
<scala.compat.version>2.13</scala.compat.version>
+
<graphframes.version>0.9.0-spark${spark.compat.version}</graphframes.version>
Review Comment:
And then this can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
