jbampton commented on PR #2171: URL: https://github.com/apache/sedona/pull/2171#issuecomment-3129386236
The pre-commit workflow is failing for the insert-license hook for the shell scripts. I can see the problem and it is very subtle. Have a look at the next two example files: This first link is the correct license template and you will see in this that there are 7 lines at the top and 6 lines at the bottom and in between is the "apache url": https://github.com/apache/sedona/blob/master/.github/workflows/license-templates/LICENSE.txt So then look at: https://github.com/apache/sedona/blob/master/docker/install-sedona.sh this is one of the shell scripts that is failing with a "TODO" license. So you can see that in this file the license header has 6 lines at the top and 5 lines at the bottom between the "apache url". So the license headers are not the same. Which means to fix this issue you need to go to all the shell scripts that have failed with "TODO" licenses and remove all the TODO licenses and then try running pre-commit again and it should insert the correct license into the shell scripts. Otherwise you can manually insert the correct license template in to the shell files and then run pre-commit to make sure the new shell license hooks passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
