jiayuasu commented on code in PR #2221:
URL: https://github.com/apache/sedona/pull/2221#discussion_r2253035507
##########
common/src/main/java/org/apache/sedona/common/S2Geography/PointGeography.java:
##########
@@ -46,8 +46,13 @@ public PointGeography() {
}
/** Constructs especially for CELL_CENTER */
- private PointGeography(GeographyKind kind, S2Point point) {
+ PointGeography(GeographyKind kind, S2Point point) {
super(kind); // can be POINT or CELL_CENTER
+ if (kind != GeographyKind.POINT
+ && kind != GeographyKind.SINGLEPOINT
+ && kind != GeographyKind.CELL_CENTER) {
+ throw new IllegalArgumentException("Invalid GeographyKind for
PolylineGeography: " + kind);
Review Comment:
Should this be `PointGeography`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
