jiayuasu commented on code in PR #2256:
URL: https://github.com/apache/sedona/pull/2256#discussion_r2264155714
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_constructors.scala:
##########
@@ -102,11 +102,11 @@ object st_constructors {
wrapExpression[ST_GeogFromText](wkt, srid)
def ST_GeogFromText(wkt: String, srid: Int): Column =
wrapExpression[ST_GeogFromText](wkt, srid)
- def ST_GeogFromWKB(wkt: Column): Column =
wrapExpression[ST_GeogFromWKB](wkt, 0)
- def ST_GeogFromWKB(wkt: String): Column =
wrapExpression[ST_GeogFromWKB](wkt, 0)
- def ST_GeogFromWKB(wkt: Column, srid: Column): Column =
- wrapExpression[ST_GeogFromWKT](wkt, srid)
- def ST_GeogFromWKB(wkt: String, srid: Int): Column =
wrapExpression[ST_GeogFromWKB](wkt, srid)
+ def ST_GeogFromWKB(wkb: Column): Column =
wrapExpression[ST_GeogFromWKB](wkb, 0)
+ def ST_GeogFromWKB(wkb: String): Column =
wrapExpression[ST_GeogFromWKB](wkb, 0)
Review Comment:
Why is this using String type? I thought we always use Binary for WKB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
