jiayuasu commented on code in PR #2271:
URL: https://github.com/apache/sedona/pull/2271#discussion_r2271539488
##########
spark/common/src/test/scala/org/apache/sedona/sql/geography/ConstructorsTest.scala:
##########
@@ -19,14 +19,35 @@
package org.apache.sedona.sql.geography
import org.apache.sedona.common.S2Geography.Geography
+import org.apache.sedona.common.geography.Constructors
import org.apache.sedona.sql.TestBaseScala
+import org.junit.Assert.assertEquals
import org.locationtech.jts.geom.PrecisionModel
class ConstructorsTest extends TestBaseScala {
import sparkSession.implicits._
val precisionModel: PrecisionModel = new
PrecisionModel(PrecisionModel.FIXED);
+ it("Passed ST_GeogFromGeoHash") {
+ var geohash = "9q9j8ue2v71y5zzy0s4q";
+ var precision = 16;
+ var row =
+ sparkSession.sql(s"SELECT ST_GeogFromGeoHash('$geohash','$precision') AS
geog").first()
+ var geoStr = row.get(0).asInstanceOf[Geography].toText(new
PrecisionModel(1e6))
+ var expectedWkt =
+ "POLYGON ((-122.3061 37.554162, -122.3061 37.554162, -122.3061
37.554162, -122.3061 37.554162, -122.3061 37.554162))"
+ assertEquals(expectedWkt, geoStr)
+
+ geohash = "s00twy01mt"
+ precision = 4;
+ row = sparkSession.sql(s"SELECT
ST_GeogFromGeoHash('$geohash','$precision') AS geog").first()
+ geoStr = row.get(0).asInstanceOf[Geography].toText(new PrecisionModel(1e6))
+ expectedWkt =
+ "POLYGON ((0.703125 0.8789062, 1.0546875 0.8789062, 1.0546875 1.0546875,
0.703125 1.0546875, 0.703125 0.8789062))"
Review Comment:
Please check SRID too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
