paleolimbot commented on code in PR #12:
URL: https://github.com/apache/sedona-db/pull/12#discussion_r2322698351
##########
rust/sedona-testing/src/compare.rs:
##########
@@ -271,26 +268,6 @@ mod tests {
);
}
- #[test]
- #[should_panic(expected = "actual ScalarValue != expected ScalarValue:
-actual ScalarValue has type Wkb(Spherical, None), expected ScalarValue has
type Wkb(Planar, None)")]
- fn value_scalar_not_equal() {
- assert_value_equal(
- &create_scalar_value(None, &WKB_GEOGRAPHY),
- &create_scalar_value(None, &WKB_GEOMETRY),
- );
- }
-
- #[test]
- #[should_panic(expected = "actual Array != expected Array:
-actual Array has type Wkb(Spherical, None), expected Array has type
Wkb(Planar, None)")]
- fn value_array_not_equal() {
- assert_value_equal(
- &create_array_value(&[], &WKB_GEOGRAPHY),
- &create_array_value(&[], &WKB_GEOMETRY),
- );
- }
-
Review Comment:
This is the other place we need to circle back to. The
`assert_value_equal()`/`assert_array_equal()`/`assert_scalar_equal()` functions
used to give nice diffs for geometry arrays, but now they can't detect that the
geometry arrays are geometry. We probably need `create_array()` to return a new
`struct ArrayWithMetadata` that works in `ScalarUdfTester::invoke_xxx()`.
`create_scalar()` should return a `Literal`, which can hold extra metadata
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
