Copilot commented on code in PR #16:
URL: https://github.com/apache/sedona-db/pull/16#discussion_r2322736528
##########
rust/sedona-functions/src/st_setsrid.rs:
##########
@@ -193,6 +198,12 @@ mod test {
assert_eq!(return_type, wkb_lnglat);
assert_value_equal(&result, &geom_lnglat);
+ // Call with an integer code of 0 (should unset the output crs)
+ let (return_type, result) =
+ call_udf(&udf, geom_lnglat.clone(),
epsg_unset_scalar.clone()).unwrap();
Review Comment:
The variable `epsg_unset_scalar` is used but it's not defined in the test.
The defined variable is `unset_scalar`. This should be `unset_scalar.clone()`.
```suggestion
call_udf(&udf, geom_lnglat.clone(),
unset_scalar.clone()).unwrap();
```
##########
rust/sedona-functions/src/st_setsrid.rs:
##########
@@ -193,6 +198,12 @@ mod test {
assert_eq!(return_type, wkb_lnglat);
assert_value_equal(&result, &geom_lnglat);
+ // Call with an integer code of 0 (should unset the output crs)
+ let (return_type, result) =
+ call_udf(&udf, geom_lnglat.clone(),
epsg_unset_scalar.clone()).unwrap();
Review Comment:
The variable `epsg_unset_scalar` is not defined. Based on the test context,
this should be `unset_scalar` which was defined on line 180.
```suggestion
call_udf(&udf, geom_lnglat.clone(),
unset_scalar.clone()).unwrap();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
