Copilot commented on code in PR #45:
URL: https://github.com/apache/sedona-db/pull/45#discussion_r2335466135
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -569,8 +569,7 @@ mod test {
let predicate = SpatialFilter::try_from_expr(&expr).unwrap();
assert!(
matches!(predicate, SpatialFilter::Intersects(_, _)),
- "Function {} should produce Intersects filter",
- func_name
+ "Function {func_name} should produce Intersects filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -583,8 +582,7 @@ mod test {
let predicate_reversed =
SpatialFilter::try_from_expr(&expr_reversed).unwrap();
assert!(
matches!(predicate_reversed, SpatialFilter::Intersects(_, _)),
- "Function {} with reversed args should produce Intersects filter",
- func_name
+ "Function {func_name} with reversed args should produce Intersects
filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
```suggestion
format!("Function {func_name} with reversed args should produce
Intersects filter")
```
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -610,8 +608,7 @@ mod test {
let predicate = SpatialFilter::try_from_expr(&expr).unwrap();
assert!(
matches!(predicate, SpatialFilter::CoveredBy(_, _)),
- "Function {} should produce CoveredBy filter",
- func_name
+ "Function {func_name} should produce CoveredBy filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -624,8 +621,7 @@ mod test {
let predicate_reversed =
SpatialFilter::try_from_expr(&expr_reversed).unwrap();
assert!(
matches!(predicate_reversed, SpatialFilter::Intersects(_, _)),
- "Function {} with reversed args should produce Intersects filter",
- func_name
+ "Function {func_name} with reversed args should produce Intersects
filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -652,8 +648,7 @@ mod test {
let predicate = SpatialFilter::try_from_expr(&expr).unwrap();
assert!(
matches!(predicate, SpatialFilter::Intersects(_, _)),
- "Function {} should produce Intersects filter",
- func_name
+ "Function {func_name} should produce Intersects filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
##########
rust/sedona-expr/src/spatial_filter.rs:
##########
@@ -667,8 +662,7 @@ mod test {
let predicate_reversed =
SpatialFilter::try_from_expr(&expr_reversed).unwrap();
assert!(
matches!(predicate_reversed, SpatialFilter::CoveredBy(_, _)),
- "Function {} with reversed args should produce CoveredBy filter",
- func_name
+ "Function {func_name} with reversed args should produce CoveredBy
filter"
Review Comment:
[nitpick] The string formatting changes from the old-style `{}` with
separate args to the new-style inline `{func_name}` are good improvements, but
these changes appear unrelated to the main purpose of the PR. Consider moving
these formatting improvements to a separate cleanup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
