jesspav commented on code in PR #38:
URL: https://github.com/apache/sedona-db/pull/38#discussion_r2337829169
##########
rust/sedona-functions/src/st_srid.rs:
##########
@@ -79,16 +103,58 @@ impl SedonaScalarKernel for StSrid {
_ => Some(0),
};
- executor.execute_wkb_void(|maybe_wkb| {
- match maybe_wkb {
- Some(_wkb) => {
- builder.append_option(srid_opt);
- }
- _ => builder.append_null(),
+ if let ColumnarValue::Array(array) = &args[0] {
+ (0..array.len()).for_each(|i| {
+ builder.append_option(if array.is_null(i) { None } else {
srid_opt });
+ });
+ } else if let ColumnarValue::Scalar(scalar) = &args[0] {
+ builder.append_option(if scalar.is_null() { None } else { srid_opt
});
+ }
Review Comment:
yeah, that does look more rusty. Forgive my noob formatting. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
