paleolimbot commented on code in PR #57:
URL: https://github.com/apache/sedona-db/pull/57#discussion_r2342122567


##########
python/sedonadb/tests/test_sjoin.py:
##########
@@ -76,3 +76,31 @@ def test_spatial_join(join_type, on):
     sedonadb_results = eng_sedonadb.execute_and_collect(sql).to_pandas()
     assert len(sedonadb_results) > 0
     eng_postgis.assert_query_result(sql, sedonadb_results)
+
+
[email protected](reason="https://github.com/apache/sedona-db/issues/63";)
+def test_spatial_join_geography(geoarrow_data):
+    eng_sedonadb = SedonaDB.create_or_skip()
+    eng_postgis = PostGIS.create_or_skip()
+
+    eng_sedonadb.create_table_parquet(
+        "sjoin_geog_all",
+        geoarrow_data
+        / "natural-earth/files/natural-earth_countries-geography_geo.parquet",
+    )
+    test_data = eng_sedonadb.execute_and_collect(
+        "SELECT * FROM sjoin_geog_all LIMIT 100"
+    )
+    eng_sedonadb.create_table_arrow("sjoin_geog", test_data)
+    eng_postgis.create_table_arrow("sjoin_geog", test_data)

Review Comment:
   I pasted this into the issue so we can track it there...in the meantime, we 
can either remove this or pick a less hard join (e.g., pick a small number of 
hard-coded or randomly generated points). This test is mostly just making sure 
that it works at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to