Copilot commented on code in PR #17:
URL: https://github.com/apache/sedona-db/pull/17#discussion_r2332028396
##########
rust/sedona-expr/src/scalar_udf.rs:
##########
@@ -594,28 +668,53 @@ mod tests {
assert!(ArgMatcher::is_geometry_or_geography().match_type(&WKB_GEOGRAPHY));
assert!(!ArgMatcher::is_geometry_or_geography()
.match_type(&SedonaType::Arrow(DataType::Binary)));
+ assert_eq!(ArgMatcher::is_geometry_or_geography().type_if_null(),
None);
assert!(ArgMatcher::is_geometry().match_type(&WKB_GEOMETRY));
assert!(!ArgMatcher::is_geometry().match_type(&WKB_GEOGRAPHY));
+ assert_eq!(ArgMatcher::is_geometry().type_if_null(),
Some(WKB_GEOMETRY));
assert!(ArgMatcher::is_geography().match_type(&WKB_GEOGRAPHY));
assert!(!ArgMatcher::is_geography().match_type(&WKB_GEOMETRY));
+ assert_eq!(
+ ArgMatcher::is_geography().type_if_null(),
+ Some(WKB_GEOGRAPHY)
+ );
assert!(ArgMatcher::is_numeric().match_type(&SedonaType::Arrow(DataType::Int32)));
assert!(ArgMatcher::is_numeric().match_type(&SedonaType::Arrow(DataType::Float64)));
+ assert_eq!(
+ ArgMatcher::is_numeric().type_if_null(),
+ Some(SedonaType::Arrow(DataType::Float64))
+ );
assert!(ArgMatcher::is_string().match_type(&SedonaType::Arrow(DataType::Utf8)));
assert!(ArgMatcher::is_string().match_type(&SedonaType::Arrow(DataType::Utf8View)));
assert!(ArgMatcher::is_string().match_type(&SedonaType::Arrow(DataType::LargeUtf8)));
assert!(!ArgMatcher::is_string().match_type(&SedonaType::Arrow(DataType::Binary)));
+ assert_eq!(
+ ArgMatcher::is_string().type_if_null(),
+ Some(SedonaType::Arrow(DataType::Utf8))
+ );
assert!(ArgMatcher::is_binary().match_type(&SedonaType::Arrow(DataType::Binary)));
assert!(ArgMatcher::is_binary().match_type(&SedonaType::Arrow(DataType::BinaryView)));
assert!(!ArgMatcher::is_binary().match_type(&SedonaType::Arrow(DataType::Utf8)));
+ assert_eq!(
+ ArgMatcher::is_binary().type_if_null(),
+ Some(SedonaType::Arrow(DataType::Binary))
+ );
assert!(ArgMatcher::is_boolean().match_type(&SedonaType::Arrow(DataType::Boolean)));
assert!(!ArgMatcher::is_boolean().match_type(&SedonaType::Arrow(DataType::Int32)));
+
assert!(ArgMatcher::is_null().match_type(&SedonaType::Arrow(DataType::Null)));
+
assert!(!ArgMatcher::is_null().match_type(&SedonaType::Arrow(DataType::Int32)));
+ assert_eq!(
+ ArgMatcher::is_boolean().type_if_null(),
+ Some(SedonaType::Arrow(DataType::Boolean))
+ );
+
assert!(ArgMatcher::is_null().match_type(&SedonaType::Arrow(DataType::Null)));
assert!(!ArgMatcher::is_null().match_type(&SedonaType::Arrow(DataType::Int32)));
Review Comment:
Lines 711-712 and 718-719 contain identical test assertions for
`ArgMatcher::is_null()`. This duplicated code should be removed to improve
maintainability.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
