Copilot commented on code in PR #79:
URL: https://github.com/apache/sedona-db/pull/79#discussion_r2346905880
##########
rust/sedona-schema/src/crs.rs:
##########
@@ -213,6 +213,8 @@ impl CoordinateReferenceSystem for AuthorityCode {
fn srid(&self) -> Result<Option<u32>> {
if self.authority.eq_ignore_ascii_case("EPSG") {
Ok(self.code.parse::<u32>().ok())
+ } else if LngLat::is_lnglat(self) {
+ Ok(Some(4326))
Review Comment:
This hardcodes SRID 4326 for all lng/lat coordinate systems. Consider
checking if this assumption is always valid, as other lng/lat coordinate
systems might exist with different SRIDs (e.g., CRS84 which is OGC's version of
WGS84).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
