Copilot commented on code in PR #2349: URL: https://github.com/apache/sedona/pull/2349#discussion_r2349904635
########## python/tests/stac/test_mock_fixtures.py: ########## @@ -0,0 +1,159 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Iterator, List, Optional, Union +from unittest.mock import create_autospec Review Comment: The MagicMock import is missing but used in the test files. Consider adding it to this fixtures file for consistency with the mock imports. ```suggestion from unittest.mock import create_autospec, MagicMock ``` ########## python/tests/stac/test_client.py: ########## @@ -16,10 +16,12 @@ # under the License. import collections.abc +from unittest.mock import patch, MagicMock Review Comment: MagicMock is imported but never used in this file. Consider removing the unused import. ```suggestion from unittest.mock import patch ``` ########## python/tests/stac/test_collection_client.py: ########## @@ -16,50 +16,67 @@ # under the License. import collections.abc +from unittest.mock import patch, MagicMock Review Comment: MagicMock is imported but never used in this file. Consider removing the unused import. ```suggestion from unittest.mock import patch ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
