Copilot commented on code in PR #83:
URL: https://github.com/apache/sedona-db/pull/83#discussion_r2350285519
##########
rust/sedona-spatial-join/src/optimizer.rs:
##########
@@ -892,9 +892,10 @@ fn is_spatial_predicate_supported(
}
match spatial_predicate {
+ // Always allow KNN predicates to preserve existing functionality
Review Comment:
[nitpick] The comment should explain why KNN predicates need to bypass type
checking rather than just stating that they do. Consider: 'KNN predicates
bypass geography type checking as they work with planar geometries and the
validation was overly restrictive'.
```suggestion
// KNN predicates bypass geography type checking as they work with
planar geometries
// and the validation was overly restrictive for their use case.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
