paleolimbot opened a new issue, #123: URL: https://github.com/apache/sedona-db/issues/123
In the lead up to the initial release, we needed to rely on a fork of the wkb crate ( https://github.com/georust/wkb , fork: https://github.com/wherobots/wkb/tree/generic-alg ) to solve performance issues with conversion to/from GEOS ( https://github.com/wherobots/wkb/blob/generic-alg/src/reader/to_geos.rs ), expose some internals, and implement a few extra geo-traits like traits to ensure iterating along sequences was as efficient as possible. This was a short-term solution and I think now that we have a release we can effectively demonstrate the motivation for some of these changes and contribute them upstream. The list will probably grow, but as a starting point: - Move https://github.com/wherobots/wkb/blob/generic-alg/src/reader/to_geos.rs into `c/sedona-geos` - Create a fresh PR from https://github.com/georust/wkb that exposes the internals required let that compile There are some internal uses of `Wkb` that are also probably no longer necessary (possibly, the ones that use `Wkb.buf()`, since we now have the `WkbBytesExecutor` that more efficiently loops over bytes without parsing them). This will have to be coordinated with the extra traits, although the extra traits I think are needed in fewer places (maybe just sedona-geo), so we could potentially scope the forked dependency to that crate while we sort out the traits. cc @Kontinuation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
