paleolimbot opened a new pull request, #149: URL: https://github.com/apache/sedona-db/pull/149
Closes #147. It turns out that bindgen-generated bindings are tricky to integrate into a lot of build systems...Windows for R was the first one but conda environments are another and the dependency on libclang is not trivial. Most recently, this caused a failure in R-universe (see the issue). This PR just hard-codes the generated bindings...in tg's case, reducing them to only the functions we use. This would be a problem if we expected the headers to change frequently, but I don't think there's much chance of our particular set of functions changing very rapidly. Apologies to @yutannihilation since this redoes the work in your earlier PR to prebuild these for Windows. I did play with that a bit but ran into the same problem you did, which was that it's tricky to generate bindings for platforms other than the one you're developing on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
