paleolimbot commented on code in PR #183:
URL: https://github.com/apache/sedona-db/pull/183#discussion_r2407980366
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -119,6 +119,29 @@ def test_st_astext(eng, geom):
eng.assert_query_result(f"SELECT ST_AsText({geom_or_null(geom)})",
expected)
+@pytest.mark.parametrize("eng", [SedonaDB, PostGIS])
+@pytest.mark.parametrize(
+ ("geom1", "geom2", "expected"),
+ [
+ # TODO: PostGIS fails without explicit ::GEOMETRY type cast, but
casting
+ # doesn't work on SedonaDB yet.
+ # (None, None, None),
Review Comment:
Thanks for catching this! We have a few cases where we're not sure exactly
what this kind of thing should do (luckily people typing SQL NULLs for this
kind of thing is pretty rare 🙂 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
