Abeeujah commented on code in PR #219:
URL: https://github.com/apache/sedona-db/pull/219#discussion_r2436501413
##########
rust/sedona-functions/src/st_isclosed.rs:
##########
@@ -92,7 +92,9 @@ fn invoke_scalar(item: &Wkb) -> Result<bool> {
is_geometry_closed(item)
}
-fn is_geometry_closed<G: GeometryTrait<T = f64>>(item: G) -> Result<bool> {
+fn is_geometry_closed(item: &Wkb) -> Result<bool> {
+ use geo_traits::GeometryCollectionTrait;
Review Comment:
:sweat_smile: It's fine on my end, Just felt like keeping the import there
instead of atop with the other imports, but yeah, I'm fine with moving it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
