petern48 commented on PR #2399: URL: https://github.com/apache/sedona/pull/2399#issuecomment-3404126217
One thing unrelated to the code changes itself. I would prefer for you to continue linking the GitHub issue (#2398) in the PR description. I don't personally care for anything else in there (maybe Jia will disagree), but linking the issue is useful because GitHub has a feature for auto-closing the issue when the PR is merged, when we link it. More importantly, if someone else stumbles across the issue, we want them to see your linked PR, so they don't try to duplicate your work before yours is merged. extra nit: I also prefer that we mention Geopandas in the PR title because the title eventually becomes the commit message after merging. (don't worry about your previous PRs). It's more descriptive in cases where anyone looks back through commit history or PR history (for debugging, for example). e.g. something like "Geopandas: Implement union" or "Implement geopandas union" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
