petern48 opened a new issue, #212: URL: https://github.com/apache/sedona-db/issues/212
We didn't have python integration tests when we originally added aliases. We should add some sort of tests to ensure python can call them. At the moment, we test only one version. In this case below, we actually test the alias and not the original function `ST_GeomFromWKT` anywhere. https://github.com/apache/sedona-db/blob/73e38fc9701deaacb8c4deba15272efb6939ddc8/python/sedonadb/tests/functions/test_functions.py#L411 Options I see: 1) Parametrize the existing test functions so all aliases are called for the entire test suite of that function ```python @pytest.mark.parametrize(func_name, ["ST_GeomFromText", "ST_GeomFromWKT"]) ... def test_st_geomfromwkt() ``` 2) Add some separate tests, just make sure the aliases are working ```python def test_st_geomfromtext_alias() # < a single query > ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
