zhangfengcdt commented on code in PR #214:
URL: https://github.com/apache/sedona-db/pull/214#discussion_r2436626582
##########
r/sedonadb/src/rust/src/dataframe.rs:
##########
@@ -109,6 +121,19 @@ impl InternalDataFrame {
Ok(())
}
+ fn to_provider(&self) -> Result<savvy::Sexp> {
+ let provider = self.inner.clone().into_view();
+ let ffi_provider =
+ FFI_TableProvider::new(provider, true,
Some(self.runtime.handle().clone()));
Review Comment:
The true parameter (for thread safety?) is hardcoded. Should this be
configurable based on the provider type? Or document it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
