prantogg commented on code in PR #2400:
URL: https://github.com/apache/sedona/pull/2400#discussion_r2430591627


##########
common/src/main/java/org/apache/sedona/common/raster/Rasterization.java:
##########
@@ -574,17 +626,18 @@ private static Map<Double, TreeSet<Double>> 
computeScanlineIntersections(
           // calculating slope
           for (double y = yStart; y >= yEnd; y--) {
             double xIntercept = p1X; // Vertical line, xIntercept is constant
-            if (xIntercept < 0 || xIntercept >= 
params.writableRaster.getWidth()) {
+            if (xIntercept < 0 || xIntercept > 
params.writableRaster.getWidth()) {

Review Comment:
   Having `>=` causes skipping of computing scanLineIntercepts treading the 
right hand side of the raster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to