petern48 commented on code in PR #184:
URL: https://github.com/apache/sedona-db/pull/184#discussion_r2404755782


##########
docs/contributors-guide.md:
##########
@@ -155,6 +155,12 @@ native component with:
 maturin develop
 ```
 
+If you don't yet have maturin installed, you can install it using pip
+
+```shell
+pip install maturin
+```
+

Review Comment:
   When I first started, I was confused why maturin wasn't already included 
after running `pip install ".[test]"`, making me hesitate whether I installed 
sedonadb correctly. I'm not sure if it was intentionally left out of the 
`pyproject.toml`, but I think we should either add it to `pyproject.toml` or if 
that's not desirable for whatever reason, add these instructions here to pip 
install it. Which do we prefer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to