petern48 commented on code in PR #2405:
URL: https://github.com/apache/sedona/pull/2405#discussion_r2442685540
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -445,6 +476,14 @@ def test_to_arrow(self):
import pyarrow as pa
for geom in self.geoms:
+ # LINEARRING EMPTY and LineString EMPTY
+ # result in 01EA03000000000000 instead of 010200000000000000.
+ # Sedona returns the right result, so this bug is likely in
pyarrow or geoarrow
+ # Below we set the modify the failing case as a workaround to pass
the test
+ # Occurs in python 3.9, but fixed by python 3.10.
+ if geom[0] in [LineString(), LinearRing()]:
+ geom[0] = LineString([(0, 0), (1, 1)])
Review Comment:
Couldn't find a PR fix in geoarrow for what exactly fixed this, but it's
[fixed in 3.10](https://github.com/petern48/sedona/actions/runs/18619253114).
I'm confident the error is not in Sedona since the following query returns the
right result. Not worth investing more time in narrowing down what the issue
was or where it was fixed, imo.
```sql
select ST_AsHEXEWKB(st_geomfromtext('linestring empty'));
-- 010200000000000000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
