petern48 commented on PR #230: URL: https://github.com/apache/sedona-db/pull/230#issuecomment-3430187101
I should've been clearer: I just meant reorder the functions you implemented recently (ie. what you did for `register.rs`), not the entire file. Hopefully you didn't spend too much time manually sorting (sorry 😓). I didn't mean to come off as the ordering is super strict (it's not). I'd guess none of the files are in the exact same order. As an FYI, they do typically tend to be in a sort of grouped alphabetical order (see this [register.rs](https://github.com/apache/sedona-db/blob/04aff75e3e69e900bc4516ddd51719ddaea62631/rust/sedona-functions/src/register.rs#L51) to see this visually). My main point is 1) you don't need to put them all at the bottom but also 2) don't stress about the ordering. Just place it where ever in the file that makes sense to you. It's unrealistic for reviewers to check and enforce a strict ordering. My main intention was to give you a heads-up for any future PRs that there is some (rough) ordering in these files, and following it can help avoid merge conflicts, which helps Dewey merge them faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
