Abeeujah commented on code in PR #234:
URL: https://github.com/apache/sedona-db/pull/234#discussion_r2452910994
##########
python/sedonadb/python/sedonadb/testing.py:
##########
@@ -269,11 +269,74 @@ def assert_result(self, result, expected, **kwargs) ->
"DBEngine":
result_pandas = self.result_to_pandas(result)
pandas.testing.assert_frame_equal(result_pandas, expected,
**kwargs)
elif isinstance(expected, list):
- result_tuples = self.result_to_tuples(result, **kwargs)
- if result_tuples != expected:
- raise AssertionError(
- f"Expected:\n {expected}\nGot:\n {result_tuples}"
- )
+ result_table = self.result_to_table(result)
+ geom_cols_schema = _geometry_columns(result_table.schema)
+
+ if geom_cols_schema:
+ import shapely
Review Comment:
Hi, your suggestion is great, gets this out of the road, and keeps a very
minimal footprint for this PR
I went with this, to help me better safeguard and prevent undefined
situations from showing up
The tests passed locally yesterday before I pushed, only for it to fail when
ran on CI the reason I could come up with might be varying dependencies in my
local and the CI environment
To better prepare and prevent that from happening again, I went with this
approach
You can review deeply to ensure it's not creating a regression or if that
would be a problem, I can go ahead with your suggestion
Either way, I'm cool with what you'd propose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
