petern48 opened a new issue, #2450: URL: https://github.com/apache/sedona/issues/2450
Our test suite for joins is quite poor at the moment. Now that I look at it, it's generally just testing if it's hooked up and not if the exact results... https://github.com/apache/sedona/blob/1eb5769be3b1ab7266a9dcecc6e3407ba28ab57a/python/tests/geopandas/test_sjoin.py#L171-L183 `test_match_geopandas_series.py` has proved to be super helpful for finding bugs in Sedona. We should replicate this for joins. In this recent [PR](https://github.com/apache/sedona/pull/2447) fix to ST_Distance, there's some suspicion that it's possible distance join is buggy on an edge case. Comparing results with geopandas would be a great way to test this. Afterwards, we should also improve our tests for the rest of sjoins and for sindexes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
