paleolimbot commented on PR #245: URL: https://github.com/apache/sedona-db/pull/245#issuecomment-3449140793
> As many people are adding geos-related functions, I pick this to avoid collision. Thank you! > At first, I thought this can be implemented via geo_traits::CoordTrait. But, I read the implementation of ST_Point and felt it's preferable to handle the raw bytes of WKB for performance. I think using `GeoTraits` or the `Wkb` object directly would be roughly equivalent in terms of performance and would be a whole lot easier to write. While we do care about performance, we also care about bug surface area and maintainability. There are some functions were we work with WKB bytes directly but all of them had simpler implementations first that we benchmarked to ensure that the complexity had measurable benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
