petern48 commented on code in PR #171: URL: https://github.com/apache/sedona-db/pull/171#discussion_r2468245065
########## rust/sedona-geometry/src/wkb_header.rs: ########## @@ -0,0 +1,728 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::types::GeometryTypeId; +use datafusion_common::{ + error::{DataFusionError, Result}, + exec_err, +}; +use geo_traits::Dimensions; +use sedona_common::sedona_internal_err; + +const SRID_FLAG_BIT: u32 = 0x20000000; + +/// Fast-path WKB header parser +/// Performs operations lazily and caches them after the first computation +pub struct WkbHeader { + geometry_type: u32, + // Not applicable for a point + // number of points for a linestring + // number of rings for a polygon + // number of geometries for a MULTIPOINT, MULTILINESTRING, MULTIPOLYGON, or GEOMETRYCOLLECTION + size: u32, + // SRID if given buffer was EWKB. Otherwise, 0. + srid: u32, + // First x,y coordinates for a point. Otherwise (f64::NAN, f64::NAN) if empty + first_xy: (f64, f64), + // Dimensions of the first nested geometry of a collection or None if empty + // For POINT, LINESTRING, POLYGON, returns the dimensions of the geometry + first_geom_dimensions: Option<Dimensions>, Review Comment: I still kinda like `first_geom_dimensions`. I don't see anything else we'd need the whole nested geometry_type for, so I think it's fine to just directly compute what I need here. If we do come across another case that it'd be useful for later, we can change it then. We can change what we store internally without breaking / removing the public `first_geom_dimensions()` api. It's only a different pattern internally. Externally there's already a `dimensions()` method, so I didn't find this off-pattern personally. in reality, i got lazy (it's late haha), so if you feel strongly i don't mind doing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
