bunnysocks opened a new pull request, #2466: URL: https://github.com/apache/sedona/pull/2466
## Did you read the Contributor Guide? - [x] Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/) ## Is this PR related to a ticket? - [x] Yes, and the PR name follows the format `[GH-2450] chore(geopandas): write sjoin match tests for dwithin()`. Closes #2450 ## What changes were proposed in this PR? This PR adds new tests to improve coverage for Sedona’s GeoPandas integration, specifically for the `sjoin()` function using the `predicate="dwithin"` parameter. **Key updates:** - Added a new test module `test_sjoin_match.py` under `sedona/python/tests/geopandas/`. - Implemented comparisons between **Sedona’s** and **GeoPandas’** `sjoin()` outputs for `dwithin()` predicate. - Covered edge cases including: - Varying distance thresholds (`0.5`, `0.05`, etc.) - Empty and small-distance joins - Type and integrity checks on returned GeoDataFrames These tests aim to ensure Sedona’s spatial join behavior matches GeoPandas’ expected results and help detect future regressions. ## How was this patch tested? - Manually verified using `pytest` locally. - Confirmed that: - Both Sedona and GeoPandas return equivalent results for valid `dwithin()` joins. - Output GeoDataFrames contain consistent left/right ID pairs. - CI will re-verify via automated testing upon PR submission. ## Did this PR include necessary documentation updates? - [x] No, this PR does not affect any public API, so no documentation changes are required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
