Copilot commented on code in PR #268: URL: https://github.com/apache/sedona-db/pull/268#discussion_r2482613226
########## rust/sedona-raster-functions/src/lib.rs: ########## @@ -0,0 +1,19 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +mod executor; +pub mod rs_size; Review Comment: The 'register' module is missing from the lib.rs exports but exists in the codebase. This module should be made public so that the default_function_set can be accessed by consumers of this library. ```suggestion pub mod rs_size; pub mod register; ``` ########## rust/sedona-raster-functions/Cargo.toml: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +[package] +name = "sedona-raster-functions" +version.workspace = true +homepage.workspace = true +repository.workspace = true +description.workspace = true +readme.workspace = true +edition.workspace = true +rust-version.workspace = true + +[lints.clippy] +result_large_err = "allow" + +[dependencies] +arrow-schema = { workspace = true } +arrow-array = { workspace = true } +arrow-buffer = { workspace = true } +datafusion-common = { workspace = true } +datafusion-expr = { workspace = true } +sedona-common = { path = "../sedona-common" } +sedona-expr = { path = "../../rust/sedona-expr" } Review Comment: The path '../../rust/sedona-expr' is inconsistent with other dependencies in this file. All other paths use '../sedona-*' format. This should be '../sedona-expr' to maintain consistency. ```suggestion sedona-expr = { path = "../sedona-expr" } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
