petern48 commented on PR #271: URL: https://github.com/apache/sedona-db/pull/271#issuecomment-3498000427
@LakshmiSowmya04 The code changes you see here have not been applied yet. While it technically is possible for maintainers to add new commits to update the PR, usually reviewers write "suggestions" instead, which is what you're seeing here. Since this is *your* PR, reviewers want to make sure *you* agree with it, so we typically avoid committing changes ourselves. Sometimes, the suggestions are debatable, so it's totally fine to reply to one saying that you disagree and elaborate why. In this case, it's mostly just nits about how to format the docs + a few additions that Dewey wants to add to the docs, so you'll likely end up just accepting all of the suggestions. If you agree with a suggestion, you can go ahead and accept it by pressing the "Commit Suggestion" button that's shown for each one. <img width="178" height="49" alt="image" src="https://github.com/user-attachments/assets/66116156-cb81-48d7-962e-3a722930db2e"; /> I encourage you to try accepting one of these now, just for one of them. Since there are many suggestions here, it might become a bit tedious to manually accept them all because GitHub reloads your screen. If you navigate to the ["Files Changed" tab](https://github.com/apache/sedona-db/pull/271/files) on this page <img width="192" height="65" alt="image" src="https://github.com/user-attachments/assets/a078a95b-6043-41e9-8467-8a596240d497"; /> ... you can click on the "Add to suggestion to batch" button for all of them and commit them all at once. I encourage you to try this too. <img width="439" height="139" alt="image" src="https://github.com/user-attachments/assets/2bc83ce6-58d0-4294-a65f-2c4c1296b576"; /> In general, reviewers will wait for you to address all suggestions, either by accepting them or by replying to them (e.g saying why you think the change is unnecessary). For this case, it looks like we'll be ready to merge after you accept all of these minor suggestions. Do please know that getting suggestions is *extremely normal* and does not mean your PR was bad. Reviewers are here to help you improve your PR to eventually get it merged, helping you grow as a developer. Oftentimes, suggestions are about code quality or conciseness. Other times, it might be about adding more tests or catching a bug. For your knowledge, everything I've said here applies to PRs in all GitHub repos, not just Sedona, so this doc PR is a great opportunity to learn and familiarize yourself with GitHub's PR submitting process before you move on to submitting code changes to this or other repos. Hope this helps! Let us know if something still isn't clear. Looking forward to getting this merged 🚀. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
