yutannihilation commented on PR #275:
URL: https://github.com/apache/sedona-db/pull/275#issuecomment-3505693060

   I think this is ready for review now, but with one caveat about the 
differences from PostGIS.
   
   First, it seems PostGIS treats `NULL` CRS and unknown (`0`) CRS differently. 
I'm not sure where we should tweak in SedonaDB to match this behavior, but I 
decided not to address it in this pull request. So, I commented out the failing 
test with some comments.
   
   ```
   postgres=# SELECT ST_SRID(ST_POINT(1, 1));
    st_srid
   ---------
          0
   (1 row)
   
   postgres=# SELECT ST_SRID(ST_POINT(1, 1, null));
    st_srid
   ---------
   
   (1 row)
   ```
   
   Also, another difference I found is that PostGIS doesn't accept CRS with 
authority e.g. `EPSG:4326` while SedonaDB accepts. I don't think this 
difference is a problem, but I'm not sure if I should include this in the test 
cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to