petern48 commented on PR #288: URL: https://github.com/apache/sedona-db/pull/288#issuecomment-3507272685
The last step is to write Python integration tests. Here I'm trying to be more comprehensive than the rust tests, covering cases that I think are edge cases. Don't worry too much if you don't know what good tests are. Just write some, push it to your PR, and us reviewers can help you here during code review. Adjust the tests until they pass. Look at surrounding code and potentially similar functions for inspiration of how to write your tests. To run the tests, I followed the [python instructions](https://github.com/apache/sedona-db/blob/94ce7db5287b39218b803eae057a4eb92a50c397/docs/contributors-guide.md#python) in the contributor guide and run this pytest command to test my exact function. It's based on the file name and test function name. ``` pytest tests/functions/test_functions.py::test_st_reverse ``` If I make changes to rust code, I run this command to update the python environment with the new changes. THIS IS IMPORTANT. If you don't run this command after making change to your rust implementation, the changes won't reflect in python. ``` maturin develop ``` Both of these commands assume you're in the `python/sedonadb/` directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
