petern48 commented on PR #292: URL: https://github.com/apache/sedona-db/pull/292#issuecomment-3508493997
Looks like there's a compile issue in your function (i.e. your code can't run). To see that, here's what I did. Clicking on the three dots on the right of one of the failed CI runs, you'll see a very helpful error message. <img width="830" height="49" alt="image" src="https://github.com/user-attachments/assets/407b7514-862f-4e8c-92fb-158cf3ca1533"; /> Though there are a few more issues than just the one it mentioned. I can tell you now that after fixing the compile error, I still see both the rust and python tests fail. For you to get this over the finish line effectively, you'll need to **run the tests locally on your laptop**, and fix up your errors one by one until they pass. At a courtesy, you should generally at least make sure to run the tests locally and make sure it compiles. (It's totally fine now that you didn't do that past time since you're new and learning. Let's just start with getting the rust tests to pass, first the rust tests locally with `cargo test` (while being in the `c/sedona-geos/` directory) to see the error message, and figure out how to fix it. Then push that commit. It's a trivial one-line change, but you need to learn how to recognize how to fix it yourself based on the error message. The tests will still fail here, since there are issues in your rust tests too. We'll handle that next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
