chay0112 commented on code in PR #2484:
URL: https://github.com/apache/sedona/pull/2484#discussion_r2508870751
##########
python/sedona/spark/geopandas/geoseries.py:
##########
@@ -973,12 +973,17 @@ def concave_hull(self, ratio=0.0, allow_holes=False):
raise NotImplementedError("This method is not implemented yet.")
@property
- def convex_hull(self):
- # Implementation of the abstract method.
- raise NotImplementedError(
- _not_implemented_error(
- "convex_hull", "Computes the convex hull of each geometry."
- )
+ def convex_hull(self) -> "GeoSeries":
+ """
+ Return the convex hull of each geometry as a new GeoSeries.
+
+ The convex hull is the smallest convex Polygon that contains
+ all the points of the geometry.
+ """
Review Comment:
Got it, thank you for the explanation ! Just addressed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
