paleolimbot commented on code in PR #298:
URL: https://github.com/apache/sedona-db/pull/298#discussion_r2524104514
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -142,6 +142,30 @@ def test_st_azimuth(eng, geom1, geom2, expected):
)
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected_boundary"),
+ [
+ (None, None),
+ ("LINESTRING(1 1, 0 0, -1 1)", "MULTIPOINT (1 1, -1 1)"),
Review Comment:
Can you add a POINT and MULTIPOINT case here? (If these error, we can put
them in a separate test and use `pytest` to assert that they consistently error
with a reasonable message)
For the GEOMETRYCOLLECTION case, you can do:
```python
@pytest.mark.parametrize(
("geom", "expected_boundary"),
[
(None, None),
("GEOMETRYCOLLECTION (...)", <whatever we think this should return>),
]
def test_st_boundary_geometrycollection():
eng = SedonaDB()
eng.assert_query_result(
f"SELECT ST_Boundary({geom_or_null(geom)})", expected_boundary
)
```
(i.e., we need to test our own behaviour no matter what)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
